feat: Add new multi-route vehicles channel #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boringcactus
reviewed
Oct 9, 2024
EmmaSimon
commented
Oct 9, 2024
| end | ||
|
|
||
| @impl true | ||
| def join("vehicles:routes:" <> topic_param_concat, _payload, socket) do |
There was a problem hiding this comment.
Why a separate topic rather than accepting a list in
route_idin the existing topic?
@boringcactus @KaylaBrady and I talked in the office yesterday, and we decided that in general we should move towards putting params into the topic names, to make it possible to connect to the same channel with different params if we need to.
boringcactus
approved these changes
Oct 9, 2024
Coverage of commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: Green Line vehicles don't load in filtered Stop Details
For the grouped green line stop pages, we need to connect to a vehicles channel that can return multiple routes at once, but the existing one only supports a single route ID. This adds a new channel which accepts any number of route IDs and returns all vehicles matching them.